[fix] Retool internal versions are not semver compliant, so ensure that our helm chart is able to support all version formats #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Java dbconnecto…"" This reverts commit 52a80d2.
…at our helm chart is able to support all version formats
jjlgao
force-pushed
the
jason/unrevert
branch
from
f0f4ffe to
a439f3e
Compare
june-xu
reviewed
Nov 22, 2024
| Older versions of Retool should always have a semver-compatible tag; only internal versions should be noncompliant. | ||
| */}} | ||
| {{- $valid_retool_version_regexp := "([0-9]+]\\.[0-9]+(\\.[0-9]+)?(-[a-zA-Z0-9]+)?)" }} | ||
| {{- $retool_version_with_java_dbconnector_opt_out := ( or ( not ( regexMatch $valid_retool_version_regexp $.Values.image.tag ) ) ( semverCompare ">= 3.93.0-0" ( regexFind $valid_retool_version_regexp $.Values.image.tag ) ) ) }} |
There was a problem hiding this comment.
reading this is tough in line, is there a helper file we can add this to lol
we can maybe put the comments in there too
There was a problem hiding this comment.
an example of a helm function: https://github.com/tryretool/retool-k8s/blob/e053bbf66ad991dbed245adf745aa4605cded79d/terragrunt/src/managed-self-hosted/helm/retool-fork/charts/postgresql/charts/common/templates/_ingress.tpl#L36-L42 we can put it in a file called _helpers.tpl
jjlgao
force-pushed
the
jason/unrevert
branch
from
88317f8 to
4173a56
Compare
jjlgao
commented
Dec 13, 2024
| @@ -27,7 +27,7 @@ jobs: | |||
| version: v3.6.3 | |||
| - uses: actions/setup-python@v4 | |||
| with: | |||
| python-version: 3.7 | |||
| python-version: 3.12 | |||
There was a problem hiding this comment.
this is because github changed the ubuntu OS so now only python 3.9-3.12 are supported
june-xu
approved these changes
Dec 13, 2024
kcheng16
pushed a commit
that referenced
this pull request
Dec 17, 2024
…at our helm chart is able to support all version formats (#196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.