Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to scale jobsRunner and WF-backend resource from main #189

Merged
merged 17 commits into from
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.2.16
version: 6.3.0
maintainers:
- name: Retool Engineering
email: [email protected]
4 changes: 4 additions & 0 deletions charts/retool/templates/deployment_jobs.yaml
Original file line number Diff line number Diff line change
@@ -179,7 +179,11 @@ spec:
{{- end }}
{{- end }}
resources:
{{- if .Values.jobRunner.resources }}
{{ toYaml .Values.jobRunner.resources | indent 10 }}
{{- else }}
{{ toYaml .Values.resources | indent 10 }}
{{- end }}
{{- if regexMatch "^([0-9]+)\\.([0-9]+)\\.([0-9]+)" .Values.image.tag }}
{{- if semverCompare ">=2.110.0-0" .Values.image.tag }}
livenessProbe:
4 changes: 4 additions & 0 deletions charts/retool/templates/deployment_workflows.yaml
Original file line number Diff line number Diff line change
@@ -252,7 +252,11 @@ spec:
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
{{- end }}
resources:
{{- if .Values.workflows.backend.resources }}
{{ toYaml .Values.workflows.backend.resources | indent 10 }}
{{- else }}
{{ toYaml .Values.resources | indent 10 }}
{{- end }}
volumeMounts:
{{- range $configFile := (keys .Values.files) }}
- name: {{ template "retool.name" $ }}
22 changes: 20 additions & 2 deletions charts/retool/values.yaml
Original file line number Diff line number Diff line change
@@ -238,7 +238,7 @@ extraVolumeMounts: []

extraVolumes: []

# These resource specifications apply to the main backend and workflows backend pods.
# These resource specifications will apply to the main backend, jobs-runner, dbconnector, and workflows-backend pods unless container specific resources are set.
resources:
# If you have more than 1 replica, the minimum recommended resources configuration is as follows:
# - cpu: 2048m
@@ -306,6 +306,15 @@ jobRunner:
# will already launch a job runner pod
# enabled: true

# If necessary, specify the resources to provision the jobRunner pod separately from the main backend pods.
# resources:
# limits:
# cpu: 4096m
# memory: 8192Mi
# requests:
# cpu: 2048m
# memory: 4096Mi

# Annotations for job runner pods
annotations: {}

@@ -346,6 +355,15 @@ workflows:
# will launch 9 pods -- 4 workflow backend, 1 workflow workers, and 4 for temporal cluster
replicaCount: 1

# If necessary, specify the resources to provision the workflows-backend pod separately from the main backend pods.
# resources:
# limits:
# cpu: 4096m
# memory: 8192Mi
# requests:
# cpu: 2048m
# memory: 4096Mi

# Timeout for queries, in ms. This will set the timeout for workflows-related pods only
# If this value is not set but config.dbConnectorTimeout is, we will set workflows pod timeouts
# to .Values.config.dbConnectorTimeout
@@ -401,7 +419,7 @@ workflows:

# Resources for the workflow worker only - these are sane inputs that bias towards stability
# Can adjust but may see OOM errors if memory too low for heavy workflow load
# To make adjustments to workflows backend, use top level resources key.
# To make adjustments to workflows backend, use workflows.backend.resources key.
resources:
limits:
cpu: 2000m
22 changes: 20 additions & 2 deletions values.yaml
Original file line number Diff line number Diff line change
@@ -238,7 +238,7 @@ extraVolumeMounts: []

extraVolumes: []

# These resource specifications apply to the main backend and workflows backend pods.
# These resource specifications will apply to the main backend, jobs-runner, dbconnector, and workflows-backend pods unless container specific resources are set.
resources:
# If you have more than 1 replica, the minimum recommended resources configuration is as follows:
# - cpu: 2048m
@@ -306,6 +306,15 @@ jobRunner:
# will already launch a job runner pod
# enabled: true

# If necessary, specify the resources to provision the jobRunner pod separately from the main backend pods.
# resources:
# limits:
# cpu: 4096m
# memory: 8192Mi
# requests:
# cpu: 2048m
# memory: 4096Mi

# Annotations for job runner pods
annotations: {}

@@ -346,6 +355,15 @@ workflows:
# will launch 9 pods -- 4 workflow backend, 1 workflow workers, and 4 for temporal cluster
replicaCount: 1

# If necessary, specify the resources to provision the workflows-backend pod separately from the main backend pods.
# resources:
# limits:
# cpu: 4096m
# memory: 8192Mi
# requests:
# cpu: 2048m
# memory: 4096Mi

# Timeout for queries, in ms. This will set the timeout for workflows-related pods only
# If this value is not set but config.dbConnectorTimeout is, we will set workflows pod timeouts
# to .Values.config.dbConnectorTimeout
@@ -401,7 +419,7 @@ workflows:

# Resources for the workflow worker only - these are sane inputs that bias towards stability
# Can adjust but may see OOM errors if memory too low for heavy workflow load
# To make adjustments to workflows backend, use top level resources key.
# To make adjustments to workflows backend, use workflows.backend.resources key.
resources:
limits:
cpu: 2000m