Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DEPLOYMENT_TEMPLATE_TYPE and VERSION to templates #149

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

avimoondra
Copy link
Contributor

@avimoondra avimoondra commented Feb 12, 2024

helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="3.20.16"  --set replicaCount=2 | rg DEPLOYMENT_TEMPLATE_TYPE -C 3
          - -c
          - chmod -R +x ./docker_scripts; sync; ./docker_scripts/wait-for-it.sh -t 0 "foo-postgresql":"5432"; ./docker_scripts/start_api.sh
        env:
          - name: DEPLOYMENT_TEMPLATE_TYPE
            value: "k8s-helm"
          - name: DEPLOYMENT_TEMPLATE_VERSION
            value: "6.0.16"
--
        securityContext:
          privileged: true
        env:
          - name: DEPLOYMENT_TEMPLATE_TYPE
            value: "k8s-helm"
          - name: DEPLOYMENT_TEMPLATE_VERSION
            value: "6.0.16"
--
          - -c
          - chmod -R +x ./docker_scripts; sync; ./docker_scripts/wait-for-it.sh -t 0 "foo-postgresql":"5432"; ./docker_scripts/start_api.sh
        env:
          - name: DEPLOYMENT_TEMPLATE_TYPE
            value: "k8s-helm"
          - name: DEPLOYMENT_TEMPLATE_VERSION
            value: "6.0.16"
--
          - -c
          - chmod -R +x ./docker_scripts; sync; ./docker_scripts/wait-for-it.sh -t 0 "foo-postgresql":"5432"; ./docker_scripts/start_api.sh
        env:
          - name: DEPLOYMENT_TEMPLATE_TYPE
            value: "k8s-helm"
          - name: DEPLOYMENT_TEMPLATE_VERSION
            value: "6.0.16"
--
          - -c
          - chmod -R +x ./docker_scripts; sync; ./docker_scripts/wait-for-it.sh -t 0 "foo-postgresql":"5432"; ./docker_scripts/start_api.sh
        env:
          - name: DEPLOYMENT_TEMPLATE_TYPE
            value: "k8s-helm"
          - name: DEPLOYMENT_TEMPLATE_VERSION
            value: "6.0.16"

related to:

@avimoondra avimoondra force-pushed the avimoondra/deployment-template-version branch 3 times, most recently from b1e77eb to 1bf16de Compare February 13, 2024 16:18
@avimoondra avimoondra force-pushed the avimoondra/deployment-template-version branch from 1bf16de to 5057fc2 Compare February 13, 2024 16:28
Comment on lines +61 to +64
- name: DEPLOYMENT_TEMPLATE_TYPE
value: {{ template "retool.deploymentTemplateType" . }}
- name: DEPLOYMENT_TEMPLATE_VERSION
value: {{ template "retool.deploymentTemplateVersion" . }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really only needed here, but in case we change the analytics implementation on boot.

(and just including code executor here as well)

@avimoondra avimoondra merged commit fa731e5 into main Feb 14, 2024
12 checks passed
@avimoondra avimoondra deleted the avimoondra/deployment-template-version branch February 14, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants