Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][DTC-5411] updated helm chart for jobs runner temporal access #122

Conversation

Sthakur27
Copy link
Contributor

@Sthakur27 Sthakur27 commented Oct 13, 2023

Updates jobs runner to put in the workflows env vars if workflows/temporal is enabled
https://linear.app/retool/issue/DTC-5411/update-docker-images-with-new-jobs-runner-env-vars

Copy link
Contributor

@avimoondra avimoondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • if you are on a version of retool that cannot leverage temporal, setting these does not affect anything.
  • if you are on a version of retool that can leverage temporal -- if temporal is not configured, jobs runner continues as is; if temporal is configured, jobs runner starts as internal worker

@@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.0.3
version: 6.0.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think 6.0.5 now

Copy link
Contributor

@avimoondra avimoondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merge, just a reminder to ourselves that in the release notes (and in docs as needed) to make sure we identify what retool version is needed to support this change.

@Sthakur27 Sthakur27 merged commit f16768b into main Oct 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants