Skip to content

Commit

Permalink
update semverCompare target to include -0 patch (#176)
Browse files Browse the repository at this point in the history
  • Loading branch information
avimoondra authored May 28, 2024
1 parent 0167443 commit 81bc3e5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.2.4
version: 6.2.5
maintainers:
- name: Retool Engineering
email: [email protected]
Expand Down
10 changes: 3 additions & 7 deletions charts/retool/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,7 @@ Usage: (include "retool.workflows.enabled" .)
{{- $output = "" -}}
{{- else if eq .Values.image.tag "latest" -}}
{{- $output = "1" -}}
{{- else if (or (contains "stable" .Values.image.tag) (contains "edge" .Values.image.tag)) -}}
{{- $output = "1" -}}
{{- else if semverCompare ">= 3.6.11" .Values.image.tag -}}
{{- else if semverCompare ">= 3.6.11-0" .Values.image.tag -}}
{{- $output = "1" -}}
{{- else -}}
{{- $output = "" -}}
Expand All @@ -242,7 +240,7 @@ Usage: (include "retool.codeExecutor.enabled" .)
{{- $output = "" -}}
{{- else if (or (contains "stable" (include "retool.codeExecutor.image.tag" .)) (contains "edge" (include "retool.codeExecutor.image.tag" .))) -}}
{{- $output = "1" -}}
{{- else if semverCompare ">= 3.20.15" (include "retool.codeExecutor.image.tag" .) -}}
{{- else if semverCompare ">= 3.20.15-0" (include "retool.codeExecutor.image.tag" .) -}}
{{- $output = "1" -}}
{{- else -}}
{{- $output = "" -}}
Expand Down Expand Up @@ -325,9 +323,7 @@ Usage: (template "retool.codeExecutor.image.tag" .)
{{- fail "If using image.tag=latest (not recommended, select an explicit tag instead) and enabling codeExecutor, explicitly set codeExecutor.image.tag" }}
{{- else if (eq .Values.image.tag "latest") -}}
{{- "" -}}
{{- else if (or (contains "stable" .Values.image.tag) (contains "edge" .Values.image.tag)) -}}
{{- .Values.image.tag -}}
{{- else if semverCompare ">= 3.20.15" .Values.image.tag -}}
{{- else if semverCompare ">= 3.20.15-0" .Values.image.tag -}}
{{- .Values.image.tag -}}
{{- else -}}
{{- "1.1.0" -}}
Expand Down

0 comments on commit 81bc3e5

Please sign in to comment.