Merge pull request #114 from tryretool/fix-postgres-subchart-usage

use the correct password for the postgresql subchart based on username

charts/retool/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: retool
 description: A Helm chart for Kubernetes
 type: application
-version: 5.0.9
+version: 5.0.10
 maintainers:
   - name: Retool Engineering
     email: [email protected]

charts/retool/templates/NOTES.txt

@@ -20,3 +20,13 @@
   echo "Visit http://127.0.0.1:8080 to use your application"
   kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 8080:$CONTAINER_PORT
 {{- end }}
+
+{{- if and .Values.postgresql.enabled (and (not .Values.postgresql.auth.postgresPassword) (eq .Values.postgresql.auth.username "postgres")) }}
+***************************************************************************
+Warning: Using in-cluster postgresql setup. `.Values.postgresql.auth.username username` is set to the default admin username "postgres", but the admin password field `.Values.postgresql.auth.postgresPassword` is not set, so a random password is generated and used. This wouldn't affect your usage, but if you choose to uninstall and reinstall this helm chart, please make sure you remove the existing PersistentVolumeClaim backing the in-cluster postgresql by running:
+  kubectl --namespace {{ .Release.Namespace }} delete pvc/data-{{ include "retool.fullname" . }}-postgresql-0
+Alternatively, you can fetch the randomly generated password and set the value in `.Values.postgresql.auth.postgresPassword` to make sure it never changes unexpectedly:
+  echo $(kubectl --namespace {{ .Release.Namespace }} get secret/{{ include "retool.fullname" . }}-postgresql -o jsonpath='{.data.postgres-password}' | base64 -d)
+We highly recommend you do NOT use this subchart as is to run Postgres in a container for your production instance of Retool. It is only suitable for proof-of-concepts. Please use a managed Postgres, or self-host more permanantly.
+***************************************************************************
+{{- end }} 

charts/retool/templates/deployment_backend.yaml

@@ -113,7 +113,13 @@ spec:
               secretKeyRef:
           {{- if  .Values.postgresql.enabled }}
                 name: {{ template "retool.postgresql.fullname" . }}
+                # `postgres` is the default admin username for postgres in the subchart we use, so it needs the admin password
+                # if a different username is picked, then it needs the custom password instead.
+                {{- if eq .Values.postgresql.auth.username "postgres" }}
                 key: postgres-password
+                {{- else }}
+                key: password
+                {{- end }}
           {{- else }}
                 {{- if .Values.config.postgresql.passwordSecretName }}
                 name: {{ .Values.config.postgresql.passwordSecretName }}

charts/retool/values.yaml

@@ -154,6 +154,8 @@ postgresql:
     database: hammerhead_production
     username: postgres
     password: retool
+    # IMPORTANT: When setting username to `postgres` a random password will be generated unless the postgresPassword field is uncommented
+    # postgresPassword: retool
   service:
     port: 5432
   # Use the offical docker image rather than bitnami/docker

values.yaml

@@ -154,6 +154,8 @@ postgresql:
     database: hammerhead_production
     username: postgres
     password: retool
+    # IMPORTANT: When setting username to `postgres` a random password will be generated unless the postgresPassword field is uncommented
+    # postgresPassword: retool
   service:
     port: 5432
   # Use the offical docker image rather than bitnami/docker