enable code executor by default for image tags >=3.20.15 (#145)

tryretool · Feb 6, 2024 · 1f2de75 · 1f2de75
1 parent 5349f37
commit 1f2de75
Show file tree

Hide file tree

Showing 7 changed files with 41 additions and 16 deletions.
diff --git a/charts/retool/Chart.yaml b/charts/retool/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: retool
 description: A Helm chart for Kubernetes
 type: application
-version: 6.0.13
+version: 6.0.14
 maintainers:
   - name: Retool Engineering
     email: [email protected]

diff --git a/charts/retool/templates/_helpers.tpl b/charts/retool/templates/_helpers.tpl
@@ -141,13 +141,11 @@ Usage: (include "retool.workflows.enabled" .)
 */}}
 {{- define "retool.workflows.enabled" -}}
 {{- $output := "" -}}
-{{- if or 
-    (eq (toString (default "" .Values.workflows.enabled)) "true")
-    (eq .Values.workflows.enabled true) 
-    (eq (toString (default "" .Values.workflows.enabled)) "false") 
-    (eq .Values.workflows.enabled false) 
+{{- if or
+    (eq (toString .Values.workflows.enabled) "true")
+    (eq (toString .Values.workflows.enabled) "false")
 -}}
-  {{- if eq .Values.workflows.enabled true -}}
+  {{- if (eq (toString .Values.workflows.enabled) "true") -}}
     {{- $output = "1" -}}
   {{- else -}}
     {{- $output = "" -}}
@@ -164,6 +162,31 @@ Usage: (include "retool.workflows.enabled" .)
 {{- $output -}}
 {{- end -}}
 
+{{/*
+Set Code Executor enabled
+Usage: (include "retool.codeExecutor.enabled" .)
+*/}}
+{{- define "retool.codeExecutor.enabled" -}}
+{{- $output := "" -}}
+{{- if or
+    (eq (toString .Values.codeExecutor.enabled) "true")
+    (eq (toString .Values.codeExecutor.enabled) "false")
+-}}
+  {{- if (eq (toString .Values.codeExecutor.enabled) "true") -}}
+    {{- $output = "1" -}}
+  {{- else -}}
+    {{- $output = "" -}}
+  {{- end -}}
+{{- else if empty .Values.codeExecutor.image.tag -}}
+  {{- $output = "" -}}
+{{- else if semverCompare ">= 3.20.15" .Values.codeExecutor.image.tag -}}
+  {{- $output = "1" -}}
+{{- else -}}
+  {{- $output = "" -}}
+{{- end -}}
+{{- $output -}}
+{{- end -}}
+
 {{/*
 Set Temporal frontend host
 */}}

diff --git a/charts/retool/templates/deployment_backend.yaml b/charts/retool/templates/deployment_backend.yaml
@@ -132,7 +132,7 @@ spec:
               {{- end }}
           {{- end }}
           {{- end }}
-          {{- if .Values.codeExecutor.enabled }}
+          {{- if include "retool.codeExecutor.enabled" . }}
           - name: CODE_EXECUTOR_INGRESS_DOMAIN
             value: http://{{ template "retool.codeExecutor.name" . }}
           {{- end }}

diff --git a/charts/retool/templates/deployment_code_executor.yaml b/charts/retool/templates/deployment_code_executor.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.codeExecutor.enabled }}
+{{- if include "retool.codeExecutor.enabled" . }}
 apiVersion: apps/v1
 kind: Deployment
 metadata:

diff --git a/charts/retool/templates/deployment_workflows_worker.yaml b/charts/retool/templates/deployment_workflows_worker.yaml
@@ -125,7 +125,7 @@ spec:
             value: {{ template "retool.postgresql.user" . }}
           - name: POSTGRES_SSL_ENABLED
             value: {{ template "retool.postgresql.ssl_enabled" . }}
-          {{- if .Values.codeExecutor.enabled }}
+          {{- if include "retool.codeExecutor.enabled" . }}
           - name: CODE_EXECUTOR_INGRESS_DOMAIN
             value: http://{{ template "retool.codeExecutor.name" . }}
           {{- end }}

diff --git a/charts/retool/values.yaml b/charts/retool/values.yaml
@@ -406,9 +406,10 @@ dbconnector:
     enabled: false
 
 codeExecutor:
-  # Enable this for Python support and running code more securely within a separate
-  # sandboxed environment
-  enabled: false
+  # enabled by default from Chart version 6.0.15 and Retool image 3.20.15 onwards
+  # explicitly set other fields as needed
+
+  # enabled: true
 
   replicaCount: 1
 

diff --git a/values.yaml b/values.yaml
@@ -406,9 +406,10 @@ dbconnector:
     enabled: false
 
 codeExecutor:
-  # Enable this for Python support and running code more securely within a separate
-  # sandboxed environment
-  enabled: false
+  # enabled by default from Chart version 6.0.15 and Retool image 3.20.15 onwards
+  # explicitly set other fields as needed
+
+  # enabled: true
 
   replicaCount: 1