Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CMakeLists.txt #148

Draft
wants to merge 1 commit into
base: debug
Choose a base branch
from
Draft

Conversation

sinterdev
Copy link

@sinterdev sinterdev commented Jan 4, 2025

This is a fairly basic CMakeLists.txt for #147, but it does have some idiosyncrasies.

  • Packages are restored from packages.config instead of being installed according to the version in the CMakeLists.txt.
  • For the Visual Studio generator, the .targets files are included, as they were in the original .vcxproj. This is non-standard.

There are also some changes from the way it was original built.

  • We now statically link to WebView2, allowing us to stop shipping the WebView2Loader.dll.

@sinterdev sinterdev marked this pull request as draft January 4, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant