feat:Add new API endpoints for tracer sessions, datasets, runs, and feedback management #127
Conversation
WalkthroughThe changes in this pull request introduce several new API endpoints related to tracer sessions, datasets, runs, and feedback management. Specifically, new functionalities include creating, updating, and deleting tracer sessions; querying and filtering datasets with download options; managing runs with statistics and grouping; and handling feedback operations, including the management of feedback ingest tokens. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/libs/LangSmith/openapi.yaml (1)
15726-15728: Document custom_action field usageThe
custom_actionfield's purpose is not clear from its title alone. Consider:
- Adding a description field explaining its usage
- Documenting valid values or patterns
- Adding examples in the schema
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (4)
src/libs/LangSmith/Generated/LangSmith.IPromptsClient.PromptCanvas.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundPromptCanvasPayload.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundPromptCanvasPayloadSecrets.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.PromptsClient.PromptCanvas.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/LangSmith/openapi.yaml(2 hunks)
🔇 Additional comments (2)
src/libs/LangSmith/openapi.yaml (2)
15729-15735: Verify template format implementation completeness
The template_format enum currently supports 'f-string' and 'mustache'. Please verify:
- Are these the only supported formats?
- Are there plans to support other common formats (e.g., Jinja2)?
#!/bin/bash
# Search for template format implementations
rg -A 5 "template.*format|templat(e|ing)"
# Look for other template engines in dependencies
fd "requirements|setup.py|package.json" --exec cat {} \; | rg "template|jinja|handlebars"15736-15740: Review security considerations for secrets handling
The secrets object allows arbitrary string properties. Consider:
- Adding schema validation for secret names/values
- Documenting security best practices
- Implementing rate limiting for endpoints using secrets
- Adding audit logging for secret usage
| @@ -15681,6 +15681,7 @@ components: | |||
| required: | |||
| - messages | |||
| - template_format | |||
| - secrets | |||
There was a problem hiding this comment.
Adding 'secrets' as a required field is a breaking change that will affect existing API clients. Consider:
- Making it optional initially
- Adding a version flag
- Providing migration guidance
Summary by CodeRabbit