-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add new endpoints and enhance existing ones in Instill AI API OpenAPI spec #47
Conversation
WalkthroughThe changes to the OpenAPI specification for the Instill AI API include the addition of multiple new endpoints for managing pipelines, models, and user interactions. Enhancements have been made to existing endpoints, improving functionality and clarity. New operations for managing pipeline releases, such as creating, updating, and deleting releases, have been introduced. The request and response schemas have been updated with additional properties, and error handling has been standardized across endpoints. Documentation improvements provide clearer descriptions and examples, particularly for complex operations. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/libs/Instill/openapi.yaml (2)
Line range hint
14-16
: Consider removing HTTP server in productionHaving an HTTP endpoint in production could expose sensitive data in transit. Consider enforcing HTTPS-only in production environments.
Apply this diff to remove the HTTP server:
servers: - url: https://api.instill.tech - - url: http://api.instill.tech
Line range hint
1-3
: Consider adding rate limiting headersWhile the API is well-structured, consider adding rate limiting headers (X-RateLimit-*) to help clients properly handle API quotas and throttling.
Some recommended headers to add:
- X-RateLimit-Limit: Maximum requests per time window
- X-RateLimit-Remaining: Remaining requests in current window
- X-RateLimit-Reset: Time when the rate limit resets
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (3)
src/libs/Instill/Generated/Instill.Models.EventSpecification.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.EventSpecificationConfigSchema.Json.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.EventSpecificationConfigSchema.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Instill/openapi.yaml
(1 hunks)
🔇 Additional comments (2)
src/libs/Instill/openapi.yaml (2)
6859-6869
: LGTM: Security scheme implementation follows best practices
The Bearer token authentication is well-documented with clear examples and follows standard practices.
6859-6869
: LGTM: Well-structured event specification schema
The EventSpecification schema provides a clear separation between configuration and message formats, with proper documentation support through examples.
Summary by CodeRabbit
New Features
Documentation