-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add GET endpoint for listing pipeline triggers with pagination and filtering #30
Conversation
WalkthroughThe changes introduce a new endpoint to the Instill API's OpenAPI specification, specifically the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/libs/Instill/openapi.yaml (1)
981-985
: Enhance pageToken parameter description.The current description lacks details about the token's format, usage, and how to obtain it for pagination.
Consider adding more details to the description:
- description: Page token. + description: "Token to retrieve the next page of results. This token is returned in the\nresponse when there are more results available. To get the next page, make the\nsame request with this token value. Leave this field empty to retrieve the first\npage."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (6)
src/libs/Instill/Generated/Instill.IMetricClient.ListPipelineTriggerRecords.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.MetricClient.ListPipelineTriggerRecords.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ListPipelineTriggerRecordsResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ListPipelineTriggerRecordsResponse2.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.PipelineTriggerRecord.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Instill/openapi.yaml (3 hunks)
🧰 Additional context used
🔇 Additional comments (1)
src/libs/Instill/openapi.yaml (1)
2313-2328
: LGTM! Well-structured schema definitions.The schema definitions for
ListPipelineTriggerRecordsResponse
andPipelineTriggerRecord
are well-designed with:
- Clear property descriptions
- Appropriate use of readOnly fields
- Proper data types
- Good reuse of existing enums
- Standard pagination pattern
Also applies to: 2605-2643
- name: pageSize | ||
in: query | ||
description: "The maximum number of triggers to return. If this parameter is unspecified,\nat most 100 pipelines will be returned. The cap value for this parameter is\n1000 (i.e. any value above that will be coerced to 100)." | ||
schema: | ||
type: integer | ||
format: int32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent pageSize limit in description.
The description states "at most 100 pipelines" but also mentions "any value above that will be coerced to 100", while the actual limit appears to be 1000 based on the text. Please clarify the correct limit and update the description accordingly.
Apply this diff to fix the description:
description: "The maximum number of triggers to return. If this parameter is unspecified,\nat most 100 pipelines will be returned. The cap value for this parameter is\n1000 (i.e. any value above that will be coerced to 100)."
+ description: "The maximum number of triggers to return. If this parameter is unspecified,\nat most 100 pipelines will be returned. The cap value for this parameter is\n1000 (i.e. any value above that will be coerced to 1000)."
Committable suggestion was skipped due to low confidence.
Summary by CodeRabbit
GET /v1beta/metrics/vdp/pipeline/triggers
.ListPipelineTriggerRecordsResponse
schema for improved data clarity.