-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Title: Update documentation for API endpoints and usage examples #10
Conversation
WalkthroughThe changes introduce a new query parameter named Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/Instill/openapi.yaml (1)
1439-1446
: Approve with suggestions: NewchunkUids
parameter looks good, but could use some enhancementsThe addition of the
chunkUids
query parameter is a good improvement to the API, allowing for more flexible querying of catalog chunks. However, consider the following suggestions to enhance its usability and documentation:
- Expand the description to provide more context, e.g., "An array of chunk unique identifiers to filter the results."
- Specify whether this parameter is required or optional.
- Consider adding a
maxItems
property to limit the number of chunk UIDs that can be provided in a single request, if applicable.Here's a suggested improvement for the parameter definition:
- name: chunkUids in: query description: "An array of chunk unique identifiers to filter the results. If provided, only chunks with matching UIDs will be returned." required: false schema: type: array items: type: string maxItems: 100 # Adjust this number as appropriate for your use case
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
src/libs/Instill/Generated/Instill.CatalogClient.ListChunks.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.ICatalogClient.ListChunks.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Instill/openapi.yaml (1 hunks)
Summary by CodeRabbit
New Features
chunkUids
to the API, allowing users to include multiple chunk unique identifiers in requests for enhanced processing capabilities.Bug Fixes
Documentation
chunkUids
parameter.