Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable skip_s3_notification to manage outside the module. #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theherk
Copy link
Contributor

@theherk theherk commented Mar 15, 2024

Since bucket notifications can only be managed once, if an implementer wants additional notifications on the bucket, they must be managed outside this module. If you give this variable as true, you must add a bucket notification to the lambda given in outputs as scan_lambda_function_arn. See this issue (#510) on the provider for more details on the topic.

This patch does not include updated README.md because I see that terraform_docs is not included in the pre-commit configuration, so I assume it is done by your pipeline.

theherk added 2 commits March 15, 2024 11:51
Since bucket notifications can only be managed once, if an implementer wants additional
notifications on the bucket, they must be managed outside this module. If you give this
variable as `true`, you *must* add a bucket notification to the lambda given in outputs
as `scan_lambda_function_arn`. See [this issue (#510) on the provider](hashicorp/terraform-provider-aws#501 (comment))
for more details on the topic.

This patch does not include updated README.md because I see that terraform_docs is not
included in the pre-commit configuration, so I assume it is done by your pipeline.
@theherk
Copy link
Contributor Author

theherk commented Mar 15, 2024

I went ahead and updated the docs using:

terraform-docs markdown table --indent 2 --output-mode inject --output-file README.md --output-template '<!-- BEGIN_TF_DOCS -->
  {{ .Content }}
  <!-- END_TF_DOCS -->' .

since the build wanted to push back to my fork rather than update after merge in your source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant