fix: allow_s3 on logs bucket and define log_prefix #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
default_allow = false
was set, not allowing any logging from AWS sources, but in order to log from S3 we needallow_s3 = true
to be set. In addition, we need thes3_logs_prefix
as well. This fixes #122.In addition, I set the
trussworks/logs/aws
module version to16.3.0
which needs this merged first. This is also what's driving the5.43.0
minimum AWS provider version as there are fixes released in that version that don't exist in versions prior. It's possible, we also wait for this PR and change thetrussworks/s3-private-bucket/aws
module version also.I also sorted the
variables.tf
and removed unused variables.