Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up to two PIN protocols #29

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

robin-nitrokey
Copy link
Member

No description provided.

Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be an enum rather than just u8

@robin-nitrokey
Copy link
Member Author

I guess there should be an enum in ctap_types. But changing the request field to use the enum would mean that we would return an error for invalid/unsupported PIN protocols already during the deserialization, which might not be correct. More importantly, it would also mean that we return the generic INVALID_CBOR error while this should typically be an INVALID_PARAMETER instead.

@robin-nitrokey robin-nitrokey merged commit f0db7ac into trussed-dev:main Feb 28, 2024
4 checks passed
@robin-nitrokey robin-nitrokey deleted the pin-protocols branch February 28, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants