Handle overlong icon values #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
approved these changes
Feb 19, 2024
sosthene-nitrokey
approved these changes
Feb 20, 2024
We skip the icon field during deserialization if it is too long. Previously, we directly tried to deserialize a String<N> and ignored any errors. This means that we also ignored any other errors, e. g. for invalid data types. This patch changes the implementation to first deserialize a string slice and handle errors occuring during the deserialization. Then we check if the string slice fits into String<N> or if we should ignore the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We skip the icon field during deserialization if it is too long. Previously, we directly tried to deserialize a String and ignored any errors. This means that we also ignored any other errors, e. g. for invalid data types.
This patch changes the implementation to first deserialize a string slice and handle errors occuring during the deserialization. Then we check if the string slice fits into String or if we should ignore the value.