Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protobuf-related utilities #1720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sfc-gh-gtokernliang
Copy link
Contributor

@sfc-gh-gtokernliang sfc-gh-gtokernliang commented Jan 11, 2025

Description

Add protobuf related utilites.

Other details good to know for developers

Preparation for OTEL span exporting

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

Important

Add protobuf utilities for OTEL span exporting, update TruLensDBSpanExporter, and add tests for new utilities.

  • Utilities:
    • Add convert_to_any_value and convert_readable_span_to_proto in exporter.py for converting data to protobuf formats.
    • Add check_if_trulens_span and construct_event for span attribute checks and event construction.
  • Exporter:
    • Update TruLensDBSpanExporter in exporter.py to use construct_event for event creation.
  • Dependencies:
    • Add opentelemetry-proto to Makefile, pyproject.toml, and requirements.txt.
  • Tests:
    • Add test_exporter.py to test convert_to_any_value for various data types.

This description was created by Ellipsis for 5fff6fc. It will automatically update as commits are pushed.

@sfc-gh-gtokernliang sfc-gh-gtokernliang marked this pull request as ready for review January 11, 2025 05:34
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant