-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cost tracking for otel_tracing #1569
Merged
+2,166
−741
Merged
Changes from 31 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6e400c8
cleaning up old PR
sfc-gh-pmardziel a09c3a2
adding cost tracking to dummy endpoint
sfc-gh-pmardziel 00e1705
finishing dummy and starting bedrock
sfc-gh-pmardziel 0add8e0
finish up
sfc-gh-pmardziel 4b748b0
replacement for track_all_costs_tally
sfc-gh-pmardziel 9180fd0
docs
sfc-gh-pmardziel 9ef5106
Merge remote-tracking branch 'origin/main' into piotrm/otel-cost-trac…
sfc-gh-pmardziel b8627c2
fixing up dummy api
sfc-gh-pmardziel 1abb615
added huggingface cost tracking for otel
sfc-gh-pmardziel 69b0e2a
working on awaitables
sfc-gh-pmardziel 54ddad3
docs
sfc-gh-pmardziel 5a36084
debugging async issue
sfc-gh-pmardziel 4f4f624
work
sfc-gh-pmardziel ca3b5eb
async parallel fixes
sfc-gh-pmardziel 4e88f2c
nit
sfc-gh-pmardziel 62f8556
Merge remote-tracking branch 'origin/main' into piotrm/otel-cost-trac…
sfc-gh-pmardziel 5686e3d
fix optional imports handling with fromlist
sfc-gh-pmardziel e491efe
remove print
sfc-gh-pmardziel a340a67
remove another print
sfc-gh-pmardziel 2835286
doc format
sfc-gh-pmardziel 1d6c2e0
put snowflake env var check back in test_endpoints
sfc-gh-pmardziel a8ec165
remove context.run
sfc-gh-pmardziel 66dd6b7
make feature private
sfc-gh-pmardziel 67d9cb6
making more things private
sfc-gh-pmardziel e703b6c
Merge remote-tracking branch 'origin/main' into piotrm/otel-cost-trac…
sfc-gh-pmardziel 5fcc28c
Merge remote-tracking branch 'origin/main' into piotrm/otel-cost-trac…
sfc-gh-pmardziel 24f31e4
add type args
sfc-gh-pmardziel 356bb2b
nits
sfc-gh-pmardziel 0ac6f5a
Merge remote-tracking branch 'origin/main' into piotrm/otel-cost-trac…
sfc-gh-pmardziel 5c73258
Merge remote-tracking branch 'origin/main' into piotrm/otel-cost-trac…
sfc-gh-pmardziel c9e2c13
addressing PR comments
sfc-gh-pmardziel c07ec92
typo
sfc-gh-pmardziel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I assume this is to avoid waiting on long blocking feedback computation. just curious what are some of the actual deadlock scenarios you've seen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen deadlocks deeper in wait_for_feedback_results which I couldn't fully explain. This change is to make things a bit more robust but wouldn't really fully address deadlocks if they are still there.