NAS-133481 / 25.04 / Changes for VMs in new virtualization

[denysbutenko]

Changes:

1. Makes CPU and Memory attributes required again.
2. Update Disks picker, remove destionation and allows to pick zvols only.
3. Updated ix-explorer allows to list zvols only.

Testing:

Checks Instance Wizard on Virtualization page.

Downstream

Affects	Reasoning
Documentation	Instance Wizard changes

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133481

[codecov]

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (3829331) to head (9b33863).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...nents/instance-wizard/instance-wizard.component.ts	85.71%	2 Missing ⚠️
src/app/services/filesystem.service.ts	71.42%	2 Missing ⚠️
...instance-disk-form/instance-disk-form.component.ts	90.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #11323   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files        1660     1660           
  Lines       59423    59440   +17     
  Branches     6244     6252    +8     
=======================================
+ Hits        49241    49257   +16     
- Misses      10182    10183    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RehanY147]

The CPU and memory field are not required on the instance wizard. You can leave them empty.

[denysbutenko]

The CPU and memory field are not required on the instance wizard. You can leave them empty.

@RehanY147 did you mean to reset value in those fields when user switches from VM to Container?

[RehanY147]

I am unclear when we want to choose zvols, can we also select directories? Or does that user has to select a zvol.
/dev/zvol as a value should not be selectable. That value is meaningless when requiring to select zvols.

[denysbutenko]

I am unclear when we want to choose zvols, can we also select directories? Or does that user has to select a zvol. /dev/zvol as a value should not be selectable. That value is meaningless when requiring to select zvols.

Middleware does not allow directories to be used and raises validation error. The ix-explorer does not support this feature yet or have it been added recently?

[undsoft]

It's fine the way it works at the moment, we can improve on it later.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.