Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133463 / 25.04 / Enable canCreateDataset in more places #11321

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

@AlexKarpov98 AlexKarpov98 self-assigned this Jan 10, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 10, 2025 09:58
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team January 10, 2025 09:58
@bugclerk bugclerk changed the title NAS-133463: Enable canCreateDataset in more places NAS-133463 / 25.04 / Enable canCreateDataset in more places Jan 10, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.74%. Comparing base (248fd2c) to head (e13a185).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11321      +/-   ##
==========================================
- Coverage   82.75%   82.74%   -0.01%     
==========================================
  Files        1654     1654              
  Lines       59132    59133       +1     
  Branches     6217     6217              
==========================================
- Hits        48934    48932       -2     
- Misses      10198    10201       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@AlexKarpov98 AlexKarpov98 merged commit 1db0212 into master Jan 13, 2025
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133463 branch January 13, 2025 10:47
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants