Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130415 / 24.10 / Unfriendly error when denying oAuth authentication #10430

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Changes:
Handling specific error when user canceled logic process (with a oAuth Cancel button).

Testing:
See ticket, result 👇

Screenshot 2024-08-12 at 13 23 41

Downstream

Affects Reasoning
Documentation New message added if user canceled oAuth login.

@AlexKarpov98 AlexKarpov98 self-assigned this Aug 12, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner August 12, 2024 10:28
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team August 12, 2024 10:28
@bugclerk bugclerk changed the title NAS-130415: Unfriendly error when denying oAuth authentication NAS-130415 / 24.10 / Unfriendly error when denying oAuth authentication Aug 12, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.00%. Comparing base (b9a1da5) to head (2be2557).

Files Patch % Lines
.../components/oauth-button/oauth-button.component.ts 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10430      +/-   ##
==========================================
- Coverage   77.01%   77.00%   -0.01%     
==========================================
  Files        1621     1621              
  Lines       55034    55039       +5     
  Branches     6466     6468       +2     
==========================================
  Hits        42384    42384              
- Misses      12650    12655       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@AlexKarpov98 AlexKarpov98 merged commit e9863dd into master Aug 12, 2024
8 of 9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-130415 branch August 12, 2024 14:06
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-130415 is targeted to the following versions which have not received their corresponding PRs: 25.04

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 12, 2024
@AlexKarpov98 AlexKarpov98 added the backport-24.10-RC.1 Electric Eel RC1 label Aug 13, 2024
@AlexKarpov98
Copy link
Contributor Author

backport

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants