NAS-129023 / 24.10 / The Time Zone applied to the Periodic Snapshot Tasks UI/Webpages are not consistent #10385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebpages are not consistent
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10385 +/- ##
==========================================
+ Coverage 77.16% 77.17% +0.01%
==========================================
Files 1609 1609
Lines 55001 55015 +14
Branches 6479 6481 +2
==========================================
+ Hits 42443 42460 +17
+ Misses 12558 12555 -3 ☔ View full report in Codecov by Sentry. |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Changed tooltip logic.
Evgeny approved:
If we are talking about a tooltip and machine time matches browser time you can just show a date. When it doesn’t you can show both:
Testing:
See it.
Try your timezone and different one.
Downstream