-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-130213 / 24.10 / Add smaller apps widgets #10378
Conversation
One thing is missing. I'll notify when it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denysbutenko - please re-request review once it's ready 😃
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10378 +/- ##
==========================================
- Coverage 76.93% 76.91% -0.02%
==========================================
Files 1608 1622 +14
Lines 54996 55135 +139
Branches 6464 6473 +9
==========================================
+ Hits 42309 42409 +100
- Misses 12687 12726 +39 ☔ View full report in Codecov by Sentry. |
@AlexKarpov98, it's ready for review but blocked for testing. The recent changes in master branch break compatibility with the DF API. Waiting for adding support to make basic app CRUD actions. |
Tracking #10394 to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR for apps changes has been merged. This PR is now unblocked #10394
Since stats are unavailable, new widgets do not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on Slack, we've decided to hide apps widgets for Electric Eel.
This PR can be merged in, but we need to hide widgets from the widget registry.
This PR has been merged and conversations have been locked. |
Changes:
Testing:
Check details in ticket