Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130213 / 24.10 / Add smaller apps widgets #10378

Merged
merged 24 commits into from
Aug 9, 2024
Merged

NAS-130213 / 24.10 / Add smaller apps widgets #10378

merged 24 commits into from
Aug 9, 2024

Conversation

denysbutenko
Copy link
Member

@denysbutenko denysbutenko commented Jul 31, 2024

Changes:

  1. Widget App Component was sliced into multiple small components
  2. Added widget-app-cpu (Quarter size)
  3. Added widget-app-memory (Quarter size)
  4. Added widget-app-info (Half size)
  5. Added widget-app-network (Half size)

image

Testing:

Check details in ticket

@denysbutenko denysbutenko requested a review from a team as a code owner July 31, 2024 07:59
@denysbutenko denysbutenko requested review from AlexKarpov98 and removed request for a team July 31, 2024 07:59
@bugclerk bugclerk changed the title NAS-130213: Slice Widget App into chunks NAS-130213 / 24.10 / Slice Widget App into chunks Jul 31, 2024
@bugclerk
Copy link
Contributor

@denysbutenko denysbutenko marked this pull request as draft July 31, 2024 08:05
@denysbutenko
Copy link
Member Author

One thing is missing. I'll notify when it is ready for review.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denysbutenko - please re-request review once it's ready 😃

@denysbutenko denysbutenko changed the title NAS-130213 / 24.10 / Slice Widget App into chunks NAS-130213 / 24.10 / Add smaller apps widgets Aug 2, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 75.81699% with 37 lines in your changes missing coverage. Please review.

Project coverage is 76.91%. Comparing base (002da50) to head (0e2af84).
Report is 2 commits behind head on master.

Files Patch % Lines
...ges/dashboard/services/widget-resources.service.ts 0.00% 8 Missing ⚠️
...s/apps/widget-app-cpu/widget-app-cpu.definition.ts 0.00% 7 Missing ⚠️
...apps/widget-app-info/widget-app-info.definition.ts 0.00% 7 Missing ⚠️
.../widget-app-memory/widget-app-memory.definition.ts 0.00% 7 Missing ⚠️
...idget-app-network/widget-app-network.definition.ts 0.00% 7 Missing ⚠️
...d/widgets/apps/widget-app/widget-app.definition.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10378      +/-   ##
==========================================
- Coverage   76.93%   76.91%   -0.02%     
==========================================
  Files        1608     1622      +14     
  Lines       54996    55135     +139     
  Branches     6464     6473       +9     
==========================================
+ Hits        42309    42409     +100     
- Misses      12687    12726      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denysbutenko denysbutenko marked this pull request as ready for review August 3, 2024 07:10
@denysbutenko
Copy link
Member Author

@AlexKarpov98, it's ready for review but blocked for testing. The recent changes in master branch break compatibility with the DF API. Waiting for adding support to make basic app CRUD actions.

@denysbutenko
Copy link
Member Author

Tracking #10394 to be merged

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR for apps changes has been merged. This PR is now unblocked #10394

@undsoft undsoft removed the blocked label Aug 7, 2024
@denysbutenko
Copy link
Member Author

Since stats are unavailable, new widgets do not work.
Half of widget-app can be tested only (app image, app version, app status)

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack, we've decided to hide apps widgets for Electric Eel.
This PR can be merged in, but we need to hide widgets from the widget registry.

@denysbutenko denysbutenko enabled auto-merge (squash) August 8, 2024 15:06
@undsoft undsoft removed the blocked label Aug 9, 2024
@denysbutenko denysbutenko merged commit 3c6657c into master Aug 9, 2024
9 checks passed
@denysbutenko denysbutenko deleted the NAS-130213 branch August 9, 2024 09:34
@bugclerk
Copy link
Contributor

bugclerk commented Aug 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants