Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanups for const/static/unused/Wformat #78

Merged
merged 1 commit into from
Oct 16, 2023
Merged

cleanups for const/static/unused/Wformat #78

merged 1 commit into from
Oct 16, 2023

Conversation

laroche
Copy link
Contributor

@laroche laroche commented Oct 15, 2023

cleanups to

  • use static for vars/functions if possible
  • use const if possible
  • fix attribute((unused)) to correct location
  • remove unused lobal vars
  • fix -Wformat warning in mquery.c

Thanks a lot for mdnsd,

Florian La Roche

@laroche
cleanups for const/static/unused/Wformat
fe57739 
cleanups to
- use static for vars/functions if possible
- use const if possible
- fix __attribute__((unused)) to correct location
- remove unused lobal vars
- fix -Wformat warning in mquery.c

Signed-off-by: Florian La Roche <[email protected]>
troglobit
troglobit approved these changes Oct 16, 2023
View reviewed changes
Copy link
Owner

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@troglobit troglobit merged commit 5346604 into troglobit:master Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laroche @troglobit