Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read AAAA records #57

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Read AAAA records #57

merged 3 commits into from
Aug 18, 2022

Conversation

fzs
Copy link
Contributor

@fzs fzs commented Aug 18, 2022

This is a first step into the IPv6 direction, relating to #10, just to see if the direction is right. This enabled querying for AAAA records and receiving responses.
The PR is in draft mode, because I would like to get PR #56 reviewed and merged first, since this one has a slight overlap.

@fzs
Copy link
Contributor Author

fzs commented Aug 18, 2022

@troglobit , can you enable running workflows?

@troglobit
Copy link
Owner

Looks good so far, to me at least :)

Appreciate very much the clean code and adherence to coding style! <3

Add IPv6 AAAA records as known record type and parse them from packets
to a mdns message.
App IPv6 address to the answer struct, so it is present in cached entries.
@fzs
Copy link
Contributor Author

fzs commented Aug 18, 2022

I have rebased the branch on top of the current master.

Yeah, I try my best to adhere to existing coding style that I see in a file. I might not really agree a 100% with all the Linux kernel rules. But you can always let me know should I deviate too much somewhere.

I don't know how much time you have to spare for this project, but your reviews and any comments you have are very welcome, as I do not have too deep familiarity with it. I am just now reworking adaption and integration a bit.

@fzs fzs marked this pull request as ready for review August 18, 2022 13:16
@troglobit
Copy link
Owner

Now that notifications work properly I'll try to give as much feedback as possible. Thank you for taking the time to communicate and contribute to the project! <3

@troglobit troglobit merged commit 8dd9781 into troglobit:master Aug 18, 2022
@fzs fzs deleted the aaaa-record branch August 18, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants