Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to julia 1.11 #207

Merged
merged 15 commits into from
Nov 26, 2024
Merged

Move to julia 1.11 #207

merged 15 commits into from
Nov 26, 2024

Conversation

benegee
Copy link
Collaborator

@benegee benegee commented Oct 10, 2024

Change to current julia version 1.11.

@benegee benegee marked this pull request as draft October 10, 2024 06:54
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (07845ab) to head (69a6d30).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   83.92%   81.84%   -2.08%     
==========================================
  Files          21       21              
  Lines         877      876       -1     
  Branches       52       52              
==========================================
- Hits          736      717      -19     
- Misses        137      155      +18     
  Partials        4        4              
Flag Coverage Δ
unittests 81.84% <100.00%> (-2.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benegee benegee marked this pull request as ready for review October 14, 2024 09:16
@benegee benegee changed the title Testing julia 1.11 Move to julia 1.11 Nov 18, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@benegee benegee mentioned this pull request Nov 18, 2024
@benegee
Copy link
Collaborator Author

benegee commented Nov 19, 2024

CI currently fails because of a memory issue with p4est examples related to the new t8code version in Trixi. @jmark
I observed this with julia 1.10.6 as well. For unknown reasons it happens with the github runners only when using julia 1.11.

@benegee
Copy link
Collaborator Author

benegee commented Nov 21, 2024

While @jmark fights relentlessly with GC, MPI, and t8code, we can get away with finalizing P4est meshes explicitly.

if mesh isa Trixi.T8codeMesh || mesh isa Trixi.P4estMesh

@benegee benegee requested a review from sloede November 21, 2024 08:29
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@benegee benegee requested a review from sloede November 24, 2024 21:05
@sloede sloede merged commit 714203f into main Nov 26, 2024
10 of 12 checks passed
@sloede sloede deleted the bg/julia-1.11 branch November 26, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants