Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and unify C and Fortran examples #133

Merged
merged 23 commits into from
Oct 20, 2023
Merged

Document and unify C and Fortran examples #133

merged 23 commits into from
Oct 20, 2023

Conversation

benegee
Copy link
Collaborator

@benegee benegee commented Oct 5, 2023

Resolves #114

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d232781) 98.05% compared to head (5723bd8) 97.98%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   98.05%   97.98%   -0.07%     
==========================================
  Files          13       13              
  Lines         565      546      -19     
==========================================
- Hits          554      535      -19     
  Misses         11       11
Flag Coverage Δ
unittests 97.98% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
examples/trixi_controller_data.c 100.00% <100.00%> (ø)
examples/trixi_controller_data.f90 100.00% <100.00%> (ø)
examples/trixi_controller_simple.c 100.00% <100.00%> (ø)
examples/trixi_controller_simple.f90 100.00% <100.00%> (ø)
examples/trixi_controller_t8code.c 100.00% <ø> (ø)
src/api.f90 97.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benegee benegee requested a review from sloede October 10, 2023 11:28
@benegee benegee marked this pull request as ready for review October 10, 2023 21:24
sloede
sloede requested changes Oct 18, 2023
View reviewed changes
LibTrixi.jl/examples/libelixir_t8code_2d_dgsem_advection_amr.jl Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
examples/.gitignore Show resolved Hide resolved
examples/trixi_controller_data.c Show resolved Hide resolved
@benegee benegee requested a review from sloede October 20, 2023 10:37
sloede
sloede previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@sloede sloede enabled auto-merge (squash) October 20, 2023 11:20
@sloede sloede disabled auto-merge October 20, 2023 11:53
@sloede sloede merged commit a47d01e into main Oct 20, 2023
7 of 8 checks passed
@sloede sloede deleted the document-examples branch October 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document examples and their purpose
2 participants
@benegee @sloede