Make PackageCompiler.jl compilation selectable in cmake #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- required JULIA_PROJECT_PATH (so does testing) - install missing - examples missing
|
So far compilation in an out-of-source build directory seems to work. Installation and examples are still missing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 13 13
Lines 565 565
=======================================
Hits 554 554
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sloede
reviewed
Sep 30, 2023
sloede
reviewed
Sep 30, 2023
sloede
reviewed
Sep 30, 2023
s.t. no init.o will end up in the source tree
- also add Fortran module
apparently necessary s.t. a rule for building libtrixi.so is generated
sloede
reviewed
Oct 4, 2023
sloede
requested changes
Oct 17, 2023
|
I also added the cmake call to the docs. Thanks for the reminder! |
sloede
reviewed
Oct 19, 2023
this allows to define dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #124
USE_PACKAGE_COMPILERJULIA_PROJECT_PATHbeing set (as does testing)