-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove normal_direction_ll
#58
Remove normal_direction_ll
#58
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 99.27% 99.27% -0.01%
==========================================
Files 61 60 -1
Lines 2630 2626 -4
==========================================
- Hits 2611 2607 -4
Misses 19 19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to merge your PR to Trixi.jl when @andrewwinters5000 agrees. Then, we can release the new version of Trixi.jl and you can update TrixiShallowWater.jl as required in this PR. Does that sound okay to you?
Yes, that sounds good to me 👍 |
The new version of Trixi.jl is released, so you can go ahead with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR removes
normal_direction_ll
from the function signature of the nonconservative terms, to account for the changes in trixi-framework/Trixi.jl#2062.