Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normal_direction_ll #58

Merged

Conversation

patrickersing
Copy link
Contributor

This PR removes normal_direction_ll from the function signature of the nonconservative terms, to account for the changes in trixi-framework/Trixi.jl#2062.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (b7c29a6) to head (fa4aebd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   99.27%   99.27%   -0.01%     
==========================================
  Files          61       60       -1     
  Lines        2630     2626       -4     
==========================================
- Hits         2611     2607       -4     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to merge your PR to Trixi.jl when @andrewwinters5000 agrees. Then, we can release the new version of Trixi.jl and you can update TrixiShallowWater.jl as required in this PR. Does that sound okay to you?

@patrickersing
Copy link
Contributor Author

I plan to merge your PR to Trixi.jl when @andrewwinters5000 agrees. Then, we can release the new version of Trixi.jl and you can update TrixiShallowWater.jl as required in this PR. Does that sound okay to you?

Yes, that sounds good to me 👍

@ranocha
Copy link
Member

ranocha commented Oct 10, 2024

The new version of Trixi.jl is released, so you can go ahead with this PR.

@patrickersing patrickersing marked this pull request as ready for review October 10, 2024 13:24
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickersing patrickersing merged commit 9f05124 into trixi-framework:main Oct 11, 2024
18 of 19 checks passed
@patrickersing patrickersing deleted the normal_direction_update branch October 11, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants