Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wavespeed estimates for SWE-Exner equations #55

Merged

Conversation

patrickersing
Copy link
Contributor

This fixes a bug where max_abs_speed and max_abs_speeds_naive didn't take absolute values into account.
To my surprise, none of the test values need to be updated as the situation with a dominant negative eigenvalue doesn't seem to occur in any of the tests.

@patrickersing patrickersing added the bug Something isn't working label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (846f4a1) to head (745be79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          61       61           
  Lines        2630     2630           
=======================================
  Hits         2611     2611           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewwinters5000 andrewwinters5000 merged commit 7e1d491 into trixi-framework:main Aug 21, 2024
19 checks passed
@patrickersing patrickersing deleted the fix_exner_wavespeed branch August 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants