-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wet/dry functionality for the 2D Multilayer-SWE #44
Add wet/dry functionality for the 2D Multilayer-SWE #44
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 99.23% 97.41% -1.83%
==========================================
Files 54 58 +4
Lines 2228 2436 +208
==========================================
+ Hits 2211 2373 +162
- Misses 17 63 +46 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @patrickersing ! Overall everything looks good to go. Just a few small corrections in the comments
examples/unstructured_2d_dgsem/elixir_shallowwater_multilayer_dam_break_dry.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Winters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We again get a few uncovered lines that should be reported as covered by testing (similar to the discussion here). We can still merge this into |
I don't think we have to worry about these uncovered lines. Looking at the coverage reports from |
da3af82
into
trixi-framework:main
Analogous to #38 this PR extends the
ShallowWaterMultiLayerEquations2D
with functionality to deal with wet/dry transitions.