Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wet/dry functionality for the 2D Multilayer-SWE #44

Merged
merged 12 commits into from
May 7, 2024

Conversation

patrickersing
Copy link
Contributor

Analogous to #38 this PR extends the ShallowWaterMultiLayerEquations2D with functionality to deal with wet/dry transitions.

@patrickersing patrickersing added the enhancement New feature or request label May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 99.06103% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.41%. Comparing base (a684879) to head (132e008).

Files Patch % Lines
...c/callbacks_stage/positivity_shallow_water_dg2d.jl 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   99.23%   97.41%   -1.83%     
==========================================
  Files          54       58       +4     
  Lines        2228     2436     +208     
==========================================
+ Hits         2211     2373     +162     
- Misses         17       63      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickersing patrickersing marked this pull request as ready for review May 3, 2024 17:38
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @patrickersing ! Overall everything looks good to go. Just a few small corrections in the comments

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewwinters5000
Copy link
Member

We again get a few uncovered lines that should be reported as covered by testing (similar to the discussion here). We can still merge this into main but we can keep an eye on these strange lines...

@patrickersing
Copy link
Contributor Author

I don't think we have to worry about these uncovered lines. Looking at the coverage reports from Trixi.jl, there are numerous untracked end lines when @threaded-loops are used. Since only the end is missing coverage, we can also be sure that everything is tested. So I think we can go ahead and merge this.

@andrewwinters5000 andrewwinters5000 merged commit da3af82 into trixi-framework:main May 7, 2024
16 of 19 checks passed
@patrickersing patrickersing deleted the 2d_ml_wetdry branch May 7, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants