Skip to content

Commit

Permalink
fix some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickersing committed May 3, 2024
1 parent 02a0c1b commit d749e81
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function initial_condition_dam_break(x, t, equations::ShallowWaterMultiLayerEqua
# stays positive. The system would not be stable for h set to a hard 0 due to division by h in
# the computation of velocity, e.g., (h v) / h. Therefore, a small dry state threshold
# with a default value of 5*eps() ≈ 1e-15 in double precision, is set in the constructor above
# for the ShallowWaterMultiLayerEquations1D and added to the initial condition if h = 0.
# for the ShallowWaterMultiLayerEquations2D and added to the initial condition if h = 0.
# This default value can be changed within the constructor call depending on the simulation setup.
for i in reverse(eachlayer(equations))
if i == nlayers(equations)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function initial_condition_discontinuous_dam_break(x, t, element_id,
# stays positive. The system would not be stable for h set to a hard 0 due to division by h in
# the computation of velocity, e.g., (h v) / h. Therefore, a small dry state threshold
# with a default value of 5*eps() ≈ 1e-15 in double precision, is set in the constructor above
# for the ShallowWaterMultiLayerEquations1D and added to the initial condition if h = 0.
# for the ShallowWaterMultiLayerEquations2D and added to the initial condition if h = 0.
# This default value can be changed within the constructor call depending on the simulation setup.
for i in reverse(eachlayer(equations))
if i == nlayers(equations)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function initial_condition_well_balancedness(x, t,
# stays positive. The system would not be stable for h set to a hard 0 due to division by h in
# the computation of velocity, e.g., (h v) / h. Therefore, a small dry state threshold
# with a default value of 5*eps() ≈ 1e-15 in double precision, is set in the constructor above
# for the ShallowWaterMultiLayerEquations1D and added to the initial condition if h = 0.
# for the ShallowWaterMultiLayerEquations2D and added to the initial condition if h = 0.
# This default value can be changed within the constructor call depending on the simulation setup.
for i in reverse(eachlayer(equations))
if i == nlayers(equations)
Expand Down
6 changes: 3 additions & 3 deletions src/equations/numerical_fluxes.jl
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ const flux_hll_chen_noelle = FluxHLL(min_max_speed_chen_noelle)
normal_direction_ll,
normal_direction_average,
equations::Trixi.AbstractEquations)
@unpack numerical_flux, hydrostatic_reconstruction = numflux
@unpack nonconservative_flux, hydrostatic_reconstruction = numflux

Check warning on line 39 in src/equations/numerical_fluxes.jl

View check run for this annotation

Codecov / codecov/patch

src/equations/numerical_fluxes.jl#L39

Added line #L39 was not covered by tests

# Create the reconstructed left/right solution states in conservative form
u_ll_star, u_rr_star = hydrostatic_reconstruction(u_ll, u_rr, equations)

Check warning on line 42 in src/equations/numerical_fluxes.jl

View check run for this annotation

Codecov / codecov/patch

src/equations/numerical_fluxes.jl#L42

Added line #L42 was not covered by tests

# Use the reconstructed states to compute the numerical surface flux
return numerical_flux(u_ll_star, u_rr_star, normal_direction_ll,
# Use the reconstructed states to compute the nonconservative surface flux
return nonconservative_flux(u_ll_star, u_rr_star, normal_direction_ll,

Check warning on line 45 in src/equations/numerical_fluxes.jl

View check run for this annotation

Codecov / codecov/patch

src/equations/numerical_fluxes.jl#L45

Added line #L45 was not covered by tests
normal_direction_average,
equations)
end
Expand Down

0 comments on commit d749e81

Please sign in to comment.