Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Static to 1, (keep existing compat) #20

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Static package from 0.8 to 0.8, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-07-18-14-54-06-813-04280782832 branch from 0ed5b92 to 65c07dc Compare July 18, 2024 14:54
@benegee
Copy link
Collaborator

benegee commented Jul 18, 2024

We need to wait for trixi-framework/Trixi.jl#1992 to test this properly

Originally posted by @ranocha in #8 (review)

@benegee
Copy link
Collaborator

benegee commented Jul 18, 2024

For some reason our workflows do not get started.

This was already observed here: trixi-framework/Trixi.jl#1953 (comment)

A workaround is to close and reopen this PR.

I opened an issue here: JuliaRegistries/CompatHelper.jl#500

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.07%. Comparing base (32fa7c7) to head (3a7f778).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   28.07%   28.07%           
=======================================
  Files           3        3           
  Lines         570      570           
=======================================
  Hits          160      160           
  Misses        410      410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tristanmontoya tristanmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me as far as I can tell.

@tristanmontoya tristanmontoya merged commit c378e92 into main Jul 25, 2024
10 checks passed
@tristanmontoya tristanmontoya deleted the compathelper/new_version/2024-07-18-14-54-06-813-04280782832 branch July 25, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants