CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat) #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranocha
force-pushed
the
compathelper/new_version/2025-01-15-00-05-29-351-00716684826
branch
from
8f8d55d to
0fe4024
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 487 487
Lines 39352 39352
=======================================
Hits 37942 37942
Misses 1410 1410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sloede
approved these changes
Jan 16, 2025
ranocha
requested changes
Jan 17, 2025
There was a problem hiding this comment.
It uses an old version in the CI tests, see https://github.com/trixi-framework/Trixi.jl/actions/runs/12809282620/job/35713778198?pr=2235#step:7:227. Please do not merge such updates where the new versions of the dependencies are not tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Makiepackage from0.19, 0.20to0.19, 0.20, 0.22.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.