Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sc/Enhanced p4est mesh views #2110

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from

Applied autoformatter.

84d22c8
Select commit
Loading
Failed to load commit list.
Draft

WIP: Sc/Enhanced p4est mesh views #2110

Applied autoformatter.
84d22c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 19, 2024 in 1s

96.27% (-0.10%) compared to bde0afc

View this Pull Request on Codecov

96.27% (-0.10%) compared to bde0afc

Details

Codecov Report

Attention: Patch coverage is 64.10256% with 42 lines in your changes missing coverage. Please review.

Project coverage is 96.27%. Comparing base (bde0afc) to head (84d22c8).

Files with missing lines Patch % Lines
src/solvers/dgsem_p4est/containers_2d.jl 3.70% 26 Missing ⚠️
src/solvers/dgsem_p4est/containers.jl 37.50% 10 Missing ⚠️
src/meshes/p4est_mesh_view.jl 89.83% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2110      +/-   ##
==========================================
- Coverage   96.37%   96.27%   -0.10%     
==========================================
  Files         486      487       +1     
  Lines       39186    39292     +106     
==========================================
+ Hits        37764    37828      +64     
- Misses       1422     1464      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov