Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normal_direction_ll for nonconservative terms #2062

Merged
merged 17 commits into from
Oct 10, 2024

Merge branch 'main' into remove_normal_direction_ll

dc95c26
Select commit
Loading
Failed to load commit list.
Merged

Remove normal_direction_ll for nonconservative terms #2062

Merge branch 'main' into remove_normal_direction_ll
dc95c26
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 1s

96.34% (-0.00%) compared to 480aea9, passed because coverage increased by 0% when compared to adjusted base (96.34%)

View this Pull Request on Codecov

96.34% (-0.00%) compared to 480aea9, passed because coverage increased by 0% when compared to adjusted base (96.34%)

Details

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.34%. Comparing base (480aea9) to head (dc95c26).

Files with missing lines Patch % Lines
src/solvers/dgmulti/flux_differencing.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2062      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.00%     
==========================================
  Files         470      470              
  Lines       37497    37495       -2     
==========================================
- Hits        36125    36123       -2     
  Misses       1372     1372              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.