-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Octavian and matmul! #1950
remove Octavian and matmul! #1950
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jc/dev_DGMulti #1950 +/- ##
===============================================
Coverage 96.15% 96.15%
===============================================
Files 454 454
Lines 36509 36509
===============================================
+ Hits 35102 35103 +1
+ Misses 1407 1406 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ranocha @JoshuaLampert I requested your reviews since you both commented on #1789. I am planning on merging PRs associated with this in a staging branch, and thought this might make it easier to review than a single large PR. Let me know if you'd prefer to proceed otherwise |
Is the MPI-macos test failure due to the Codecov issue when the PR is from a fork of the repo? |
Yes, exactly. It would be easier if you could make the PRs from branches in the main repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine as a first step. Thanks
54f55e0
into
trixi-framework:jc/dev_DGMulti
Thanks for taking care of this @jlchan! |
Would address #1906, and is the first step in addressing #1789.