Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: t8code cubed spherical shell setups #1918

Merged
merged 119 commits into from
Dec 18, 2024

Conversation

jmark
Copy link
Contributor

@jmark jmark commented Apr 26, 2024

This is a follow-PR to #1900.

It implements two cubed spherical shell setups and uses the latest t8code v2.0.0 v3.0.X release.

Closes #1921

This PR depends on a new patch release by t8code. More specifically, this PR: DLR-AMR/t8code#1296

Johannes Markert and others added 29 commits April 8, 2024 13:04
…mework/Trixi.jl into feature-t8code-curved-geometry
it refers to level of refinement in lat lon direction, not number of
tree as in the p4est version
…mework/Trixi.jl into feature-t8code-curved-geometry
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

benegee and others added 2 commits November 5, 2024 18:55
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
test/test_t8code_3d.jl Outdated Show resolved Hide resolved
@benegee benegee mentioned this pull request Nov 6, 2024
13 tasks
@jmark jmark changed the title Feature: t8code cubed spherical shell setups & testing t8code v3.0.0. Feature: t8code cubed spherical shell setups Nov 7, 2024
@benegee
Copy link
Contributor

benegee commented Dec 17, 2024

Finally!

t8code's latest patch release v3.0.1 contains @jmark's long desired fix for the cubed sphere.

This is now ready to be reviewed and merged!

JoshuaLampert
JoshuaLampert previously approved these changes Dec 18, 2024
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I see that the new baroclinic instability test takes roughly 20 seconds in CI, which is, I think, on the border of being acceptable. We could consider reducing the time span even more, but I would also be fine with the current version as the t8code_part2 job doesn't take so long so far.

@benegee
Copy link
Contributor

benegee commented Dec 18, 2024

Thanks for your help @JoshuaLampert . I would be fine with reducing the runtime. The only argument I can think of is that we would like to reproduce the corresponding p4est test here.

@JoshuaLampert
Copy link
Member

The only argument I can think of is that we would like to reproduce the corresponding p4est test here.

Yeah, that makes sense.

Co-authored-by: Joshua Lampert <[email protected]>
@benegee benegee enabled auto-merge (squash) December 18, 2024 18:28
@benegee benegee merged commit bde0afc into main Dec 18, 2024
40 checks passed
@benegee benegee deleted the feature-t8code-cubed-sphere-setup branch December 18, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants