-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: t8code cubed spherical shell setups #1918
Conversation
…mework/Trixi.jl into feature-t8code-curved-geometry
it refers to level of refinement in lat lon direction, not number of tree as in the p4est version
…mework/Trixi.jl into feature-t8code-curved-geometry
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…framework/Trixi.jl into feature-t8code-cubed-sphere-setup
…framework/Trixi.jl into feature-t8code-cubed-sphere-setup
Finally! t8code's latest patch release v3.0.1 contains @jmark's long desired fix for the cubed sphere. This is now ready to be reviewed and merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I see that the new baroclinic instability test takes roughly 20 seconds in CI, which is, I think, on the border of being acceptable. We could consider reducing the time span even more, but I would also be fine with the current version as the t8code_part2 job doesn't take so long so far.
Thanks for your help @JoshuaLampert . I would be fine with reducing the runtime. The only argument I can think of is that we would like to reproduce the corresponding p4est test here. |
Yeah, that makes sense. |
Co-authored-by: Joshua Lampert <[email protected]>
This is a follow-PR to #1900.
It implements two cubed spherical shell setups and uses the latest t8code
v2.0.0v3.0.X release.Closes #1921
This PR depends on a new patch release by t8code. More specifically, this PR: DLR-AMR/t8code#1296