Perk p2 single ext #1908
Merged
Perk p2 single ext #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructor modified
Add constructor of PERK3
Co-authored-by: Daniel Doehring <[email protected]>
Perk p2p3 single
… into PERK_p2p3_Single
Co-authored-by: Daniel Doehring <[email protected]>
|
Are we good to go here? |
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
ranocha
reviewed
May 15, 2024
There was a problem hiding this comment.
Fine with me when the comment of @JoshuaLampert is resolved.
ranocha
reviewed
May 16, 2024
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
ranocha
approved these changes
May 17, 2024
JoshuaLampert
approved these changes
May 17, 2024
5 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
in this PR which is a continuation of the previous PR of PERK2_single, I tried to make Convex and ECOS weak dependencies of Trixi by adding a file called TrixiConvexECOSExt.
Please let me know if something goes wrong and needs improving!