-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend TimeSeriesCallback for TreeMesh1D/3D #1873
Extend TimeSeriesCallback for TreeMesh1D/3D #1873
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
=======================================
Coverage 96.30% 96.31%
=======================================
Files 439 440 +1
Lines 35749 35797 +48
=======================================
+ Hits 34428 34476 +48
Misses 1321 1321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I also tested convergence by running the test elixirs with refined meshes and comparing the gauge point data ( Results for
Results for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks very good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I just left one suggestion to avoid code duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR extends the
TimeSeriesCallback
onTreeMesh
to 1D and 3D.The existing routines worked pretty much out of the box and the extension only required one additional function. Since many of the methods in
time_series_dg_2d.jl
are actually independent of mesh and dimension, I would suggest to relocate them intotime_series_dg.jl
.Furthermore, since most functions for
TreeMesh
are independent of the dimension, I think it makes sense to split these off into a filetime_series_dg_tree.jl
to avoid code duplication.