-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check BCs for periodicity for periodic Tree & Structured meshes #1860
Check BCs for periodicity for periodic Tree & Structured meshes #1860
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
src/semidiscretization/semidiscretization_hyperbolic_parabolic.jl
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 96.30% 96.30% -0.00%
==========================================
Files 438 438
Lines 35577 35603 +26
==========================================
+ Hits 34259 34284 +25
- Misses 1318 1319 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Motivated by #752
This puts out warnings if a mesh with periodic boundaries is used, but still BCs are supplied.
The converse case, where a non-periodic mesh and periodic BCs are paired returns an error, so no additional treatment is added here.