-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for CairoMakie to 0.11 for package test, (keep existing compat) #1841
base: main
Are you sure you want to change the base?
CompatHelper: bump compat for CairoMakie to 0.11 for package test, (keep existing compat) #1841
Conversation
…eep existing compat)
17e7ab1
to
9eb80a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
==========================================
- Coverage 89.67% 84.31% -5.36%
==========================================
Files 458 458
Lines 36400 36396 -4
==========================================
- Hits 32640 30686 -1954
- Misses 3760 5710 +1950
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Aha, there are some breaking changes that affect us:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to adapt this to the breaking changes and update the compat settings afterwards.
@jlchan this looks like it could be code from you. Would you be able to take a look at this? |
This pull request changes the compat entry for the
CairoMakie
package from0.6, 0.7, 0.8, 0.9, 0.10
to0.6, 0.7, 0.8, 0.9, 0.10, 0.11
for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.