WIP: Sc/polytropic 2d wave speed #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added interface coupling docs to the main menu.
Moved converter coupling section.
Added some documentation on coupling converters.
Co-authored-by: Hendrik Ranocha <[email protected]>
…rixi.jl into sc/converters_coupling
Co-authored-by: Daniel Doehring <[email protected]>
|
Please start from a clean state for future PRs. This one includes a huge amount of unrelated history. |
|
Restarting this PR from a clean state. |
|
Sorry, that's not necessary for this one. I would just like to ask you to start with a clean state in the future. We can go ahead with this one as it is - whatever you prefer |
Just add the usual rotation and consistency tests. They pass locally. |
DanielDoehring
previously approved these changes
Feb 6, 2024
The bug should be fixed now. |
|
Anything that prevents this from being merged @andrewwinters5000 @SimonCan ? |
andrewwinters5000
requested changes
Feb 15, 2024
Co-authored-by: Andrew Winters <[email protected]>
DanielDoehring
approved these changes
Feb 15, 2024
andrewwinters5000
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wave speeds to the PolytropicEulerEquations2D equations.