-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moist Euler equations with warm bubble test case #1813
base: main
Are you sure you want to change the base?
Conversation
This reverts commit b6e527b.
Co-authored-by: Andrew Winters <[email protected]>
Co-authored-by: Andrew Winters <[email protected]>
Co-authored-by: Andrew Winters <[email protected]>
Co-authored-by: Andrew Winters <[email protected]>
Thanks sloede!
…k/Trixi.jl into add-warm-bubble-test-case
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
- introduce AbstractCompressibleEulerMulticomponentEquations{2} holding all common methods - introducde CompressibleMoistEulerEquations2D with methods that need to take into account latent heat - CompressibleEulerMulticomponentEquations{2} holds those methods in their original formulation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 96.30% 91.60% -4.70%
==========================================
Files 439 442 +3
Lines 35749 36307 +558
==========================================
- Hits 34428 33259 -1169
- Misses 1321 3048 +1727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR restructures
CompressibleEulerMulticomponentEquations
AbstractCompressibleEulerMulticomponentEquations{2}
is introduced as another abstract type. All common methods are implemented for this abstract typeCompressibleEulerMulticomponentEquations{2}
now is a subtype ofAbstractCompressibleEulerMulticomponentEquations{2}
. It holds the data (gammas, gas constants, ...) as before. Methods depending on that data are implemented for this type as before.CompressibleMoistEulerEquations2D
is introduced as another subtype ofCompressibleEulerMulticomponentEquations
. Compared toCompressibleEulerMulticomponentEquations
the latent head of vaporization is added. Methods needing to account for it are implemented for this type, possibly overriding common methods.Also a test case is added.
Part of #1778