Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moist Euler equations with warm bubble test case #1813

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

benegee
Copy link
Contributor

@benegee benegee commented Jan 25, 2024

This PR restructures CompressibleEulerMulticomponentEquations

  • AbstractCompressibleEulerMulticomponentEquations{2} is introduced as another abstract type. All common methods are implemented for this abstract type
  • CompressibleEulerMulticomponentEquations{2} now is a subtype of AbstractCompressibleEulerMulticomponentEquations{2}. It holds the data (gammas, gas constants, ...) as before. Methods depending on that data are implemented for this type as before.
  • CompressibleMoistEulerEquations2D is introduced as another subtype of CompressibleEulerMulticomponentEquations. Compared to CompressibleEulerMulticomponentEquations the latent head of vaporization is added. Methods needing to account for it are implemented for this type, possibly overriding common methods.

Also a test case is added.

Part of #1778

benegee and others added 30 commits December 18, 2023 13:37
benegee and others added 6 commits January 10, 2024 16:50
- introduce AbstractCompressibleEulerMulticomponentEquations{2} holding
  all common methods
- introducde CompressibleMoistEulerEquations2D with methods that need to
  take into account latent heat
- CompressibleEulerMulticomponentEquations{2} holds those methods in their original formulation
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: Patch coverage is 43.40474% with 502 lines in your changes are missing coverage. Please review.

Project coverage is 91.60%. Comparing base (2dfde7f) to head (1e4e76d).

Files Patch % Lines
...ions/compressible_euler_multicomponent_moist_2d.jl 0.00% 195 Missing ⚠️
...red_2d_dgsem/elixir_eulermultimoist_warm_bubble.jl 0.00% 165 Missing ⚠️
...s/compressible_euler_multicomponent_abstract_2d.jl 79.91% 85 Missing ⚠️
.../equations/compressible_euler_multicomponent_2d.jl 45.19% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
- Coverage   96.30%   91.60%   -4.70%     
==========================================
  Files         439      442       +3     
  Lines       35749    36307     +558     
==========================================
- Hits        34428    33259    -1169     
- Misses       1321     3048    +1727     
Flag Coverage Δ
unittests 91.60% <43.40%> (-4.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant