Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnalysisSurfaceIntegral #1812

Merged

Conversation

Arpit-Babbar
Copy link
Member

@Arpit-Babbar Arpit-Babbar commented Jan 24, 2024

This PR adds a callback to compute forces on the surface of a body, like the surface of an airfoil. Three examples, each having steady state solutions, have been added

  1. A transonic flow over NACA0012 using Compressible Navier-Stokes code. This is the most convincing because I have matched values with Table 3 of this paper
  2. A flow over NACA0012 airfoil using Compressible Euler code having AMR.
  3. Subsonic flow over cylinder.

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (73da92c) to head (2810499).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
+ Coverage   96.30%   96.32%   +0.02%     
==========================================
  Files         441      445       +4     
  Lines       35799    35926     +127     
==========================================
+ Hits        34476    34605     +129     
+ Misses       1323     1321       -2     
Flag Coverage Δ
unittests 96.32% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanielDoehring DanielDoehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for bringing this functionality to Trixi!

I added some first mostly implementation-related comments.

Please also add a test for the new elixir, such that the newly added code becomes part of our CI runs.

src/callbacks_step/analysis_surface_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_2d.jl Outdated Show resolved Hide resolved
@Arpit-Babbar Arpit-Babbar force-pushed the surface_pressure_forces branch from 2badb17 to 9e95c37 Compare January 24, 2024 15:41
@Arpit-Babbar Arpit-Babbar force-pushed the surface_pressure_forces branch from 1a704d6 to 78f22d1 Compare February 10, 2024 15:24
@Arpit-Babbar Arpit-Babbar changed the title Add AnalysisSurfaceIntegral WIP: Add AnalysisSurfaceIntegral Feb 10, 2024
@Arpit-Babbar Arpit-Babbar force-pushed the surface_pressure_forces branch 2 times, most recently from 0621431 to ac87bed Compare February 10, 2024 16:20
@JoshuaLampert
Copy link
Member

Why is the formatter making so many changes? I get failing CI if I don't run formatter in all files.

See #1842.

@Arpit-Babbar
Copy link
Member Author

Why is the formatter making so many changes? I get failing CI if I don't run formatter in all files.

See #1842.

Ah, thank you so much!

@Arpit-Babbar Arpit-Babbar force-pushed the surface_pressure_forces branch from 004fa97 to bc04f60 Compare February 14, 2024 08:24
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment to open a discussion on how to grab the boundary indices that should be integrated over.

@Arpit-Babbar Arpit-Babbar force-pushed the surface_pressure_forces branch 2 times, most recently from 3276bbb to 9b0915a Compare February 16, 2024 05:07
@DanielDoehring DanielDoehring marked this pull request as ready for review March 27, 2024 15:43
@Arpit-Babbar Arpit-Babbar changed the title WIP: Add AnalysisSurfaceIntegral Add AnalysisSurfaceIntegral Mar 27, 2024
@DanielDoehring
Copy link
Contributor

DanielDoehring commented Mar 27, 2024

@Arpit-Babbar I took the liberty to push this a little further as I want to do some actual aerodynamic simulations which also involve lift (and especially drag) coefficients due to viscous forces.

For this, the coefficients due to pressure should be merged first.

DanielDoehring
DanielDoehring previously approved these changes Mar 27, 2024
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice additional feature. Most of my comments / suggestions are related to notation and variable names.

NEWS.md Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_integral_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_integral_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_integral_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_integral_2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/analysis_surface_integral_2d.jl Outdated Show resolved Hide resolved
Some key points

1) Change pre to p
2) Don't capitalize U
3) Don't append Swanson quantities with 'sw' 
4) linf -> l_inf (may be pending in some other places)
5) Other formatting improvements

Co-authored-by: Andrew Winters <[email protected]>
NEWS.md Outdated Show resolved Hide resolved
@DanielDoehring DanielDoehring added the enhancement New feature or request label Mar 29, 2024
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks @Arpit-Babbar och @DanielDoehring this is a very nice feature to add to Trixi.

@DanielDoehring DanielDoehring merged commit 57f4b20 into trixi-framework:main Mar 30, 2024
37 checks passed
@Arpit-Babbar Arpit-Babbar deleted the surface_pressure_forces branch March 30, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants