-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Sc/p4est view #1761
base: main
Are you sure you want to change the base?
WIP: Sc/p4est view #1761
Conversation
More to come, especially bug fixing.
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
- Coverage 96.34% 96.34% -0.00%
==========================================
Files 470 471 +1
Lines 37497 37577 +80
==========================================
+ Hits 36125 36201 +76
- Misses 1372 1376 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merge branch 'main' into sc/p4est-view
This should be part of a coupling branch.
Added a few comments, mostly todos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ixi.jl into sc/p4est-view
This is currently not used.
Structures that create a view on a p4est mesh, similar to the structured mesh views implemented earlier. This is intended to be used on coupled simulations, but can be used for un-coupled as well.
This is a 0th iteration and provides some basic framework for some of the more exciting features to come in the next PRs.