-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add local and global limiting for StructuredMesh #1739
WIP: Add local and global limiting for StructuredMesh #1739
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
===========================================
- Coverage 96.31% 73.53% -22.78%
===========================================
Files 440 443 +3
Lines 35797 35950 +153
===========================================
- Hits 34476 26435 -8041
- Misses 1321 9515 +8194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Using new PR #1942 now. |
Adding the subcell local and global limiting support for StructuredMesh.
Getting the inverse Jacobian makes this PR a bit longer. That's because for TreeMesh,
inverse_jacobian
is fixed for one element, while it is different for each node for StructuredMesh.To avoid something like
and also avoid unnecessary calls of inverse jacobian in TreeMesh simulations,
I dispatched for the mesh type and extracted the code
[...]
to an inner function.After this PR, it will be straight forward to add support for P4estMesh.
For now, there is no support for non-conservative systems.
For now, I only added a free stream test including local and global limiting. Though, I think it doesn't make sense to merge another free stream elixir to main.
I will add a more interesting elixir (also for testing all new code) and delete the free stream elixir then.