Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in 2D CEE HLLE Noncartesian flux #1719

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix bug in 2D CEE HLLE Noncartesian flux #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a57f7f9
Fix bug
DanielDoehring Nov 8, 2023
24b836d
Merge branch 'main' into FixBugHLLE_2D_CEE_NonCartesian
DanielDoehring Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/equations/compressible_euler_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ of the numerical flux.
v1_roe = (sqrt_rho_ll * v1_ll + sqrt_rho_rr * v1_rr) * inv_sum_sqrt_rho
v2_roe = (sqrt_rho_ll * v2_ll + sqrt_rho_rr * v2_rr) * inv_sum_sqrt_rho
v_roe = v1_roe * normal_direction[1] + v2_roe * normal_direction[2]
v_roe_mag = (v1_roe * normal_direction[1])^2 + (v2_roe * normal_direction[2])^2
v_roe_mag = v1_roe^2 + v2_roe^2

H_roe = (sqrt_rho_ll * H_ll + sqrt_rho_rr * H_rr) * inv_sum_sqrt_rho
c_roe = sqrt((equations.gamma - 1) * (H_roe - 0.5 * v_roe_mag)) * norm_
Expand Down
16 changes: 8 additions & 8 deletions test/test_p4est_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,16 @@ end
@trixi_testset "elixir_euler_sedov.jl (HLLE)" begin
@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_sedov.jl"),
l2=[
0.411541263324004,
0.2558929632770186,
0.2558929632770193,
1.298715766843915,
0.40853279043747015,
0.25356771650524296,
0.2535677165052422,
1.2984601729572691,
],
linf=[
1.3457201726152221,
1.3138961427140758,
1.313896142714079,
6.293305112638921,
1.3840909333784284,
1.3077772519086124,
1.3077772519086157,
6.298798630968632,
],
surface_flux=flux_hlle,
tspan=(0.0, 0.3))
Expand Down
4 changes: 2 additions & 2 deletions test/test_unit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,7 +1191,7 @@ end
u_values = [SVector(1.0, 0.5, -0.7, 1.0),
SVector(1.5, -0.2, 0.1, 5.0)]
fluxes = [flux_central, flux_ranocha, flux_shima_etal, flux_kennedy_gruber,
flux_hll, FluxHLL(min_max_speed_davis)]
flux_hll, FluxHLL(min_max_speed_davis), flux_hlle]

for f_std in fluxes
f_rot = FluxRotated(f_std)
Expand All @@ -1215,7 +1215,7 @@ end
SVector(1.5, -0.2, 0.1, 0.2, 5.0)]
fluxes = [flux_central, flux_ranocha, flux_shima_etal, flux_kennedy_gruber,
FluxLMARS(340),
flux_hll, FluxHLL(min_max_speed_davis)]
flux_hll, FluxHLL(min_max_speed_davis), flux_hlle]

for f_std in fluxes
f_rot = FluxRotated(f_std)
Expand Down
Loading