-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format test directory #1688
format test directory #1688
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1688 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 430 430
Lines 34474 34474
=======================================
Hits 33142 33142
Misses 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I checked roughly half of the test files. They look okay - if we ignore the issue linked above by Joshua. I think we can go ahead an merge this when tests pass - okay, @sloede? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, due to the special structure with lots of macros etc., formatting test/
does not really improve readability (I'd say it's a lateral movement, at best). However, for the sake of consistency and developer friendly auto-formatting, I say we still go ahead.
LGTM, thanks for tackling it!
I ran JuliaFormatter to format our
test
folder and will check whether it looks correct. Any help with that is appreciated!