Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase type stab, avoid allocs #1642

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Increase type stab, avoid allocs #1642

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be3c65c
Increase type stab, avoid allocs
DanielDoehring Sep 18, 2023
b696212
format
DanielDoehring Sep 18, 2023
cc4adfc
Merge branch 'main' into TypeStabilityBCsUnstructured
DanielDoehring Sep 19, 2023
b2116e1
test seems no longer broken
DanielDoehring Sep 19, 2023
8664544
Merge branch 'TypeStabilityBCsUnstructured' of github.com:DanielDoehr…
DanielDoehring Sep 19, 2023
2e626cd
only essentials
DanielDoehring Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/solvers/dgsem_unstructured/dg_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,8 @@ function calc_boundary_flux!(cache, t, boundary_condition::BoundaryConditionPeri
end

# Function barrier for type stability
function calc_boundary_flux!(cache, t, boundary_conditions,
function calc_boundary_flux!(cache, t,
boundary_conditions::UnstructuredSortedBoundaryTypes,
mesh::Union{UnstructuredMesh2D, P4estMesh, T8codeMesh},
equations, surface_integral, dg::DG)
@unpack boundary_condition_types, boundary_indices = boundary_conditions
Expand Down Expand Up @@ -357,9 +358,9 @@ function calc_boundary_flux_by_type!(cache, t, BCs::Tuple{}, BC_indices::Tuple{}
nothing
end

function calc_boundary_flux!(cache, t, boundary_condition, boundary_indexing,
function calc_boundary_flux!(cache, t, boundary_condition::BC, boundary_indexing,
mesh::UnstructuredMesh2D, equations,
surface_integral, dg::DG)
surface_integral, dg::DG) where {BC}
@unpack surface_flux_values = cache.elements
@unpack element_id, element_side_id = cache.boundaries

Expand All @@ -383,12 +384,12 @@ end

# inlined version of the boundary flux calculation along a physical interface where the
# boundary flux values are set according to a particular `boundary_condition` function
@inline function calc_boundary_flux!(surface_flux_values, t, boundary_condition,
@inline function calc_boundary_flux!(surface_flux_values, t, boundary_condition::BC,
mesh::UnstructuredMesh2D,
nonconservative_terms::False, equations,
surface_integral, dg::DG, cache,
node_index, side_index, element_index,
boundary_index)
boundary_index) where {BC}
DanielDoehring marked this conversation as resolved.
Show resolved Hide resolved
@unpack normal_directions = cache.elements
@unpack u, node_coordinates = cache.boundaries
@unpack surface_flux = surface_integral
Expand Down Expand Up @@ -417,12 +418,12 @@ end
# Note, it is necessary to set and add in the nonconservative values because
# the upper left/lower right diagonal terms have been peeled off due to the use of
# `derivative_split` from `dg.basis` in [`flux_differencing_kernel!`](@ref)
@inline function calc_boundary_flux!(surface_flux_values, t, boundary_condition,
@inline function calc_boundary_flux!(surface_flux_values, t, boundary_condition::BC,
mesh::UnstructuredMesh2D,
nonconservative_terms::True, equations,
surface_integral, dg::DG, cache,
node_index, side_index, element_index,
boundary_index)
boundary_index) where {BC}
DanielDoehring marked this conversation as resolved.
Show resolved Hide resolved
surface_flux, nonconservative_flux = surface_integral.surface_flux
@unpack normal_directions = cache.elements
@unpack u, node_coordinates = cache.boundaries
Expand Down